feat: Complete stub services with real implementations and graceful not-configured responses
All checks were successful
Test Asgard Runner / test (push) Successful in 2s
All checks were successful
Test Asgard Runner / test (push) Successful in 2s
- ChangelogService: inject PlatformChangelog repo, query with findAndCount(skip/take), return actual data
- ChangelogModule: add TypeOrmModule.forFeature([PlatformChangelog])
- MapsService: add uploadMap() — SHA-256 checksum, storage path, full entity save
- MapsController: add POST /maps/upload with FileInterceptor, map.manage permission, @UploadedFile
- AuthService: replace console.log stubs with Logger; forgotPassword returns 200 with clear message; resetPassword throws NotImplementedException
- PluginsService: searchUmod returns { results: [], message: 'not yet configured' } instead of bare []
- SteamService: add Logger.warn on every stub path (checkForceWipe, getPlayerSummary)
- SettingsService: add Logger; both Cloudflare DNS stubs emit Logger.warn before DB save
- MigrationService: add Logger; exportConfig logs warning + returns note field; importConfig throws NotImplementedException
- Install @types/multer dev dependency for Express.Multer.File type support
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -11,14 +11,16 @@ export class SteamService {
|
||||
}
|
||||
|
||||
async checkForceWipe(): Promise<{ isForceWipe: boolean; expectedDate: string | null }> {
|
||||
// Stub — would check Steam API for Rust staging branch updates
|
||||
this.logger.warn('Steam API not configured — checkForceWipe returning stub response');
|
||||
return { isForceWipe: false, expectedDate: null };
|
||||
}
|
||||
|
||||
async getPlayerSummary(steamId: string): Promise<{ personaname: string; avatarfull: string } | null> {
|
||||
if (!this.apiKey) return null;
|
||||
// Stub — would call ISteamUser/GetPlayerSummaries/v2
|
||||
this.logger.debug(`Would fetch Steam profile for ${steamId}`);
|
||||
if (!this.apiKey) {
|
||||
this.logger.warn('Steam API not configured — getPlayerSummary returning null');
|
||||
return null;
|
||||
}
|
||||
this.logger.warn(`Steam API not configured — skipping profile fetch for ${steamId}`);
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user